Skip to content

[release-line-0.4.1] only filter cometbft ports by migrations #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moritzkiefer-da merged 2 commits into from
Jun 23, 2025
Merged

[release-line-0.4.1] only filter cometbft ports by migrations #1205

moritzkiefer-da merged 2 commits into from
Jun 23, 2025

Conversation

@moritzkiefer-da
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da commented Jun 23, 2025

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@cocreature
Revert "[release-line-0.4.1] Limit cometbft load balancer ports to on…
135c626 
…ly those actually used (#1193)"

This reverts commit efaea62.

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@cocreature
Only filter cometbft ports by migrations
2e8eab7 
Changing the dependency structure is too much of a mess and this seems
good enough.

[static]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da enabled auto-merge (squash) June 23, 2025 15:48
@moritzkiefer-da moritzkiefer-da merged commit c5f2f21 into release-line-0.4.1 Jun 23, 2025
39 checks passed
@moritzkiefer-da moritzkiefer-da deleted the cocreature/0.4.1-migrations branch June 23, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OriolMunoz-da OriolMunoz-da OriolMunoz-da approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moritzkiefer-da @OriolMunoz-da @cocreature